Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerView.toggleControllerVisibility() has a bug on version 2.10.3 #6260

Closed
brucewuu520 opened this issue Aug 4, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@brucewuu520
Copy link

Version: 2.10.3

when i not use default PlayerControlView,when click PlayerView application is error
error log:
com.google.android.exoplayer2.ui.PlayerView.toggleControllerVisibility(PlayerView.java:1156)
at com.google.android.exoplayer2.ui.PlayerView.performClick(PlayerView.java:1075)

in PlayerView method:

private boolean toggleControllerVisibility() {
if (!controller.isVisible()) {
maybeShowController(true);
} else if (controllerHideOnTouch) {
controller.hide();
}
return true;
}

has not check useController

but in version 2.10.2:

private boolean toggleControllerVisibility() {
if (!useController || player == null) {
return false;
}
if (!controller.isVisible()) {
maybeShowController(true);
} else if (controllerHideOnTouch) {
controller.hide();
}
return true;
}

@tonihei
Copy link
Collaborator

tonihei commented Aug 5, 2019

Thanks for reporting. Looks like we don't check for custom controller when performClick is called directly.

ojw28 pushed a commit that referenced this issue Aug 5, 2019
@ojw28 ojw28 closed this as completed Aug 5, 2019
ojw28 pushed a commit that referenced this issue Aug 5, 2019
@google google locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants