Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioTrackPositionTracker returns negative timestamps after reset #7456

Closed
tonihei opened this issue Jun 2, 2020 · 1 comment
Closed

AudioTrackPositionTracker returns negative timestamps after reset #7456

tonihei opened this issue Jun 2, 2020 · 1 comment
Assignees
Labels

Comments

@tonihei
Copy link
Collaborator

tonihei commented Jun 2, 2020

[REQUIRED] Issue description

AudioTrackPositionTracker sometimes returns a negative timestamps immediately after a reset (e.g. at the start of playback, or after a seek). This causes the rendererPositionUs in ExoPlayerImplInternal to be negative, which in turn violates other assumptions the player and the renderers make about the position. This issue was originally reported in #7449. The PR proposed a workaround for this problem for the total buffered duration specifically, but it should ideally be fixed closer to the root cause.

[REQUIRED] Reproduction steps

Play "Apple TS media playlist" in the demo app and add logging similar to this one. The issue doesn't happen after all resets, but only occasionally.

[REQUIRED] Link to test content

"Apple TS media playlist" in the demo app

[REQUIRED] A full bug report captured from the device

Not relevant.

[REQUIRED] Version of ExoPlayer being used

dev-v2

[REQUIRED] Device(s) and version(s) of Android being used

Pixel 4, Android 11. Probably unrelated.

@ojw28 ojw28 self-assigned this Jun 2, 2020
@ojw28 ojw28 removed the needs triage label Jun 2, 2020
ojw28 added a commit that referenced this issue Jun 2, 2020
@ojw28
Copy link
Contributor

ojw28 commented Jun 2, 2020

Should be fixed by the commit ref'd above.

@ojw28 ojw28 closed this as completed Jun 2, 2020
ojw28 added a commit that referenced this issue Jun 3, 2020
@google google locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants