Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve handling of audio session IDs #8190

Closed
master255 opened this issue Nov 9, 2020 · 4 comments
Closed

Fix and improve handling of audio session IDs #8190

master255 opened this issue Nov 9, 2020 · 4 comments
Assignees
Labels

Comments

@master255
Copy link

@ojw28 Perhaps you need to pay special attention to AudiosessionId, and to test its work properly?
I regularly come across the fact that it does not work:
#6954.
#6975

ExoPlayer 2.12.0
Android 4.4 audio session stops transmitting data after rewinding and when you switch to the next track. There are no errors or notifications in the logs.

mMediaPlayer.getAudioSessionId() - method does not work. It regularly returns 0 at the time when the session number is different.

@ojw28
Copy link
Contributor

ojw28 commented Nov 10, 2020

If you want us to investigate this, please provide proper reproduction steps, ideally in the form of a minimal test app. Note that #6954 also lacked clear reproduction steps, to the extent that it's still unclear whether there was a bug. #6975 also lacked clear reproduction steps until 12 messages in, and when they were finally provided we were able to provide a clear answer.

@google-oss-bot

This comment has been minimized.

@master255

This comment has been minimized.

@ojw28 ojw28 added bug and removed needs triage labels Dec 1, 2020
@ojw28 ojw28 changed the title Audiosession again does not work! Improve handling of audio session IDs Dec 1, 2020
@ojw28 ojw28 changed the title Improve handling of audio session IDs Fix and improve handling of audio session IDs Dec 1, 2020
icbaker pushed a commit that referenced this issue Jan 7, 2021
Overriding this method will never be necessary or advisable once we
improve routing of audio session IDs

Issue: #8190
PiperOrigin-RevId: 350146302
icbaker pushed a commit that referenced this issue Jan 7, 2021
@ojw28
Copy link
Contributor

ojw28 commented Jan 13, 2021

Handling of audio session IDs is much improved in a95b2eb, which will be in 2.13.0.

@ojw28 ojw28 closed this as completed Jan 13, 2021
@google google locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants