-
Notifications
You must be signed in to change notification settings - Fork 358
Add power function and test to backend #846
Conversation
Before code can be merged, it needs to "build", which means for example that pylint and pytest have to run successfully. You can tell whether your code has built properly by looking at the line marked "continuous-integration/travis-ci/pr", which will have a red X / green checkmark upon failure/success. The same symbols appear next to the PR in the PR list. If the code doesn't build, you can click Details on the same line to see which configurations have failed, and then click on any one of them to see the console output from each. In your case the error is quite simple: line 1001 in abstract_backend.py exceeds the maximum character limit of 80 characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly! Fix the small formatting issues here and I'll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good. Fix the build and I'll merge.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 129 129
Lines 22103 22109 +6
=======================================
+ Hits 21743 21749 +6
Misses 360 360
Continue to review full report at Codecov.
|
First step as proposed in #840 to add support for the np.power function.