Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Add power function and test to backend #846

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Add power function and test to backend #846

merged 2 commits into from
Oct 5, 2020

Conversation

wkostuch
Copy link
Contributor

@wkostuch wkostuch commented Oct 1, 2020

First step as proposed in #840 to add support for the np.power function.

@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@alewis
Copy link
Contributor

alewis commented Oct 1, 2020

Before code can be merged, it needs to "build", which means for example that pylint and pytest have to run successfully. You can tell whether your code has built properly by looking at the line marked "continuous-integration/travis-ci/pr", which will have a red X / green checkmark upon failure/success. The same symbols appear next to the PR in the PR list.

If the code doesn't build, you can click Details on the same line to see which configurations have failed, and then click on any one of them to see the console output from each. In your case the error is quite simple: line 1001 in abstract_backend.py exceeds the maximum character limit of 80 characters.

Copy link
Contributor

@alewis alewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly! Fix the small formatting issues here and I'll merge.

tensornetwork/backends/abstract_backend.py Outdated Show resolved Hide resolved
tensornetwork/backends/abstract_backend.py Show resolved Hide resolved
tensornetwork/backends/abstract_backend.py Outdated Show resolved Hide resolved
tensornetwork/backends/abstract_backend.py Outdated Show resolved Hide resolved
tensornetwork/backends/backend_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@alewis alewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good. Fix the build and I'll merge.

tensornetwork/backends/abstract_backend.py Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #846 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         129      129           
  Lines       22103    22109    +6     
=======================================
+ Hits        21743    21749    +6     
  Misses        360      360           
Impacted Files Coverage Δ
tensornetwork/backends/abstract_backend.py 92.30% <100.00%> (+0.09%) ⬆️
tensornetwork/backends/backend_test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27f269...62c379a. Read the comment docs.

@alewis alewis merged commit 8451862 into google:master Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants