Add darwin_x86_64 CPU handling #4329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently bazel supports `darwin` and `darwin_x86_64` as meaning the same thing. The fully qualified version is normally used if you're cross compiling from M1 machines to intel machines. I'm also hoping to remove the unqualified version to reduce confusion. This change makes it compatible with both for now.
|
@fbarchard @alankelly could one of you take a look? |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
PiperOrigin-RevId: 558837158
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
PiperOrigin-RevId: 558837158
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
PiperOrigin-RevId: 558837158
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
PiperOrigin-RevId: 558837158
|
This is fixed in 16bb890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bazel supports
darwinanddarwin_x86_64as meaning the same thing. The fully qualified version is normally used if you're cross compiling from M1 machines to intel machines. I'm also hoping to remove the unqualified version to reduce confusion. This change makes it compatible with both for now.