Remove TODOs for DeviceConfigurationOverride

google · Feb 1, 2024 · 4b3cf17 · 4b3cf17
1 parent 7e722bd
commit 4b3cf17
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 107 deletions.
diff --git a/adaptive/src/sharedTest/kotlin/com/google/accompanist/adaptive/TwoPaneTest.kt b/adaptive/src/sharedTest/kotlin/com/google/accompanist/adaptive/TwoPaneTest.kt
@@ -91,11 +91,7 @@ class TwoPaneTest {
                     strategy = FractionHorizontalTwoPaneStrategy(
                         splitFraction = 1f / 3f
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -156,11 +152,7 @@ class TwoPaneTest {
                     strategy = FractionHorizontalTwoPaneStrategy(
                         splitFraction = 1f / 3f
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -222,11 +214,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f,
                         gapWidth = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -288,11 +276,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f,
                         gapWidth = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -352,11 +336,7 @@ class TwoPaneTest {
                     strategy = FractionVerticalTwoPaneStrategy(
                         splitFraction = 1f / 3f
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -417,11 +397,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f,
                         gapHeight = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -483,11 +459,7 @@ class TwoPaneTest {
                         splitOffset = 200.dp,
                         offsetFromStart = true,
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -549,11 +521,7 @@ class TwoPaneTest {
                         splitOffset = 200.dp,
                         offsetFromStart = true,
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -616,11 +584,7 @@ class TwoPaneTest {
                         offsetFromStart = true,
                         gapWidth = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -683,11 +647,7 @@ class TwoPaneTest {
                         offsetFromStart = true,
                         gapWidth = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -748,11 +708,7 @@ class TwoPaneTest {
                         splitOffset = 300.dp,
                         offsetFromTop = true
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -814,11 +770,7 @@ class TwoPaneTest {
                         offsetFromTop = true,
                         gapHeight = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -879,11 +831,7 @@ class TwoPaneTest {
                         splitOffset = 300.dp,
                         offsetFromTop = false
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -945,11 +893,7 @@ class TwoPaneTest {
                         offsetFromTop = false,
                         gapHeight = 64.dp
                     ),
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1017,11 +961,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1096,11 +1036,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1175,11 +1111,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1254,11 +1186,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1333,11 +1261,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1412,11 +1336,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }
@@ -1492,11 +1412,7 @@ class TwoPaneTest {
                         splitFraction = 1f / 3f
                     ),
                     displayFeatures = displayFeatures,
-                    modifier = Modifier
-                        // TODO: This should not be necessary, remove once
-                        //       https://issuetracker.google.com/issues/322354080 is fixed
-                        .requiredSize(900.dp, 1200.dp)
-                        .onPlaced { twoPaneCoordinates = it }
+                    modifier = Modifier.onPlaced { twoPaneCoordinates = it }
                 )
             }
         }

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -1,9 +1,9 @@
 [versions]
 
-compose = "1.7.0-alpha01"
+compose = "1.7.0-SNAPSHOT"
 composeCompiler = "1.5.8"
 composeMaterial3 = "1.0.1"
-composesnapshot = "-" # a single character = no snapshot
+composesnapshot = "11391981" # a single character = no snapshot
 
 dokka = "1.8.10"