[SystemUiController] Add Dialog and custom Window support #1114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional, nullable
Window
parameter torememberSystemUiController
.The default value of this parameter is a multi-step fallback:
Window
will be pulled from theDialogWindowProvider
(if available), which will return theWindow
corresponding to aDialog
managed byCompose
.Window
will be attempted to be retrieved from theActivity
(which matches current behavior).null
.If both methods fail, then no
Window
will be available, andsystemUiController
will degrade in behavior (which is useful for@Preview
usage).Additionally, a specific
Window
can be passed directly as an argument, which is useful in cases where the default behavior will fail (for example, if aComposeView
is being used inside of aDialog
or aDialogFragment
)I added a new
Dialog
sample to showcase the new behavior, and the remainder of this PR's content is tests.This fixes #1110