Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log skipped files in verbose mode #112

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Only log skipped files in verbose mode #112

merged 2 commits into from
Aug 26, 2022

Conversation

talal
Copy link
Contributor

@talal talal commented Jun 21, 2022

This PR changes the default behavior of logging all skipped files to instead logging the skipped files only in verbose mode (with -v flag).

Motivation

When a ton of files are skipped (e.g. -ignore vendor/**) then the output of addlicense becomes quite verbose and the actual output which we are interested in, i.e. which files were modified or which files are missing license info when -check is used, gets buried in between the skipping log lines.

P.S. I have also updated the usage instructions in the README with the up-to-date flag information as per addlicense --help.

@google-cla
Copy link

google-cla bot commented Jun 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@talal
Copy link
Contributor Author

talal commented Jun 28, 2022

@willnorris can you have a look at the PR? I have already signed the CLA.

Feel free to close it, if you don't want to change the app behavior :)

@braydonk
Copy link

+1 for this! Really hope this gets merged 🤞

@willnorris
Copy link
Collaborator

Sorry, I missed seeing this when it was originally submitted, but yeah this seems totally reasonable.

@willnorris willnorris merged commit 09bb508 into google:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants