Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read license from file (take 2) #14

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Conversation

jmccann
Copy link
Contributor

@jmccann jmccann commented Nov 30, 2018

Picking up #1 to be able to read a license template from a file for more versatility.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jmccann jmccann changed the title Custom license picked Read license from file (take 2) Nov 30, 2018
@jmccann
Copy link
Contributor Author

jmccann commented Nov 30, 2018

I signed it!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@jmccann
Copy link
Contributor Author

jmccann commented Nov 30, 2018

@bradrydzewski Not sure if you still cared about #1 but I updated it to work with current master. Please allow me to use your code. 😄

Copy link
Contributor

@x1ddos x1ddos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @bradrydzewski has already signed Google's CLA in the past, judging from the successful checks in #1. So, it's all good.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@x1ddos x1ddos mentioned this pull request Nov 30, 2018
x1ddos and others added 2 commits November 30, 2018 11:25
Co-Authored-By: jmccann <jmccann.git@gmail.com>
Co-Authored-By: jmccann <jmccann.git@gmail.com>
@x1ddos x1ddos merged commit 1e1ee45 into google:master Nov 30, 2018
@x1ddos
Copy link
Contributor

x1ddos commented Nov 30, 2018

Thanks @jmccann

@jmccann jmccann deleted the custom-license-picked branch November 30, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants