Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more file types #15

Merged
merged 3 commits into from
Dec 20, 2018
Merged

Conversation

thefirstofthe300
Copy link
Contributor

@thefirstofthe300 thefirstofthe300 commented Dec 19, 2018

My team needs support for Ruby files, Dockerfiles, Gemfiles, and Groovy files. This commit adds support for all of these file types.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@thefirstofthe300 thefirstofthe300 changed the title Add groovy support Add support for more file types Dec 19, 2018
Copy link
Contributor

@x1ddos x1ddos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments.

testdata/expected/Gemfile Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@x1ddos x1ddos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits.
Thanks for swapping Google Inc. => Google LLC. Forgot to do it.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Adds support for Dockerfiles, Gemfiles, Ruby files, and Groovy files.
Also, in order to fully support Dockerfile and Gemfiles, a new file
extension parser was created to deal with files that do not have an
extension.
@x1ddos
Copy link
Contributor

x1ddos commented Dec 20, 2018

Thank you!

@x1ddos x1ddos merged commit 7af3504 into google:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants