-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more file types #15
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
2392090
to
16ba6da
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few comments.
410e16d
to
4562c61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits.
Thanks for swapping Google Inc. => Google LLC. Forgot to do it.
Adds support for Dockerfiles, Gemfiles, Ruby files, and Groovy files. Also, in order to fully support Dockerfile and Gemfiles, a new file extension parser was created to deal with files that do not have an extension.
4562c61
to
9aa15d9
Compare
9aa15d9
to
76290e6
Compare
Thank you! |
My team needs support for Ruby files, Dockerfiles, Gemfiles, and Groovy files. This commit adds support for all of these file types.