Add Docker support. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone of the maintainers please review and merge this PR? |
mco-gh
reviewed
Sep 6, 2020
| @@ -0,0 +1,10 @@ | |||
| FROM golang:1-alpine AS build-env | |||
|
|
|||
| RUN apk add --no-cache --upgrade git openssh-client ca-certificates | |||
There was a problem hiding this comment.
thanks for this PR. Why do you need openssh-client and ca-certificates?
There was a problem hiding this comment.
Hi @marcacohen, this is required for the go get -u github.com/google/addlicense command to succeed (since this is done over HTTPS).
I can recheck regarding the openssh-client, but I'm almost sure that it didn't work without it.
You can see other examples of the same thing on other repositories, e.g.:
https://github.com/projectdiscovery/httpx/blob/master/Dockerfile
Thanks!
There was a problem hiding this comment.
Ok, that makes sense. Thanks for the PR and sorry for the delay!
mco-gh
approved these changes
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please review and consider merging this PR which adds Docker support to addlicense.
Thanks,
Rotem