Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build failure due to upstream golang/dep deprecation unfixed issue #72

Closed
wants to merge 1 commit into from

Conversation

Chaffelson
Copy link

Fixes #71
Uses suggestion from upstream Issue at golang/dep#2223 (comment)

Uses suggestion from upstream Issue at golang/dep#2223 (comment)
@google-cla
Copy link

google-cla bot commented Apr 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Chaffelson
Copy link
Author

@googlebot I signed it!

Copy link

@dockerzhang dockerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for me.

@willnorris
Copy link
Collaborator

Thanks for the fix! We ended up doing a larger rewrite of the Dockerfile in #82 which also ended up fixing this.

@willnorris willnorris closed this Aug 9, 2021
@Chaffelson Chaffelson deleted the fix_issue71 branch August 10, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build fails due to upstream dep issue
3 participants