Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker instructions to include GitHub container registry #93

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

willnorris
Copy link
Collaborator

I don't love using ghcr.io/google/addlicense even for the local build instructions (rather than just google/addlicense), but it does make the later instructions to test and run the image consistent. At the end of the day, probably not a big deal.

@willnorris willnorris requested a review from mco-gh August 16, 2021 23:32
@codecov-commenter
Copy link

Codecov Report

Merging #93 (612dddd) into master (2fe3ee9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files           2        2           
  Lines         246      246           
=======================================
  Hits          117      117           
  Misses        122      122           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe3ee9...612dddd. Read the comment docs.

@willnorris willnorris merged commit 944049f into google:master Aug 17, 2021
@willnorris willnorris deleted the docker branch August 17, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants