Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning about Android NDK version #305

Closed
tobine opened this issue May 27, 2020 · 2 comments
Closed

Build warning about Android NDK version #305

tobine opened this issue May 27, 2020 · 2 comments
Assignees

Comments

@tobine
Copy link
Contributor

tobine commented May 27, 2020

Environment information:

  • AGI version: Latest master
  • Host OS: Windows

Bug description
When building on Windows I see the warning:

WARNING: The major revision of the Android NDK referenced by android_ndk_repository rule 'androidndk' is 21. The major revisions supported by Bazel are [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]. Bazel will attempt to treat the NDK as if it was r20. This may cause compilation and linkage problems. Please download a supported NDK version.

This contradicts the build documentation that states:

The minimum required version of the NDK is r21.

Reproduction steps
Steps to reproduce the behavior:
Pull latest code and build according to the instructions

@hevrard
Copy link
Contributor

hevrard commented May 27, 2020

NDK r21 is not yet supported in Bazel, see: bazelbuild/bazel#10811

Still, we're using it to have access to the unified Khronos validation layer. We never had an NDK-related issue after the update to r21, so I think it's safe to ignore this warning.

What is left to do is to ass to our build documentation that this warning is expected, I'll take care of that.

@hevrard
Copy link
Contributor

hevrard commented Jun 1, 2020

Fixed by: #307

@hevrard hevrard closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants