Update to google-assistant-{library,grpc}==0.1.0 #207

drigz · 2017-12-22T17:40:31Z

This doesn't update from v1alpha1 of the gRPC API to v1alpha2, which is to follow, but appears to be mostly search-and-replace.

I've not yet tested this on the Voice Kit hardware (or even on a machine with a microphone - I only have access to a Chromebook right now). I'm concerned that upgrading the library breaks the button+library demo as reported in #204. However, that's separate to the Device / Model ID logic.

The Device ID is currently unused, but it may be required for the gRPC API, and would be required if we want to use Device Actions, so it makes sense to keep it.

@proppy, how can we specify the language? I can't see any way to specify it for the Google Assistant Library, and the gRPC docs still say only en-US is supported.

This doesn't update from v1alpha1 of the gRPC API to v1alpha2, which is to follow.

PeterMalkin · 2017-12-22T21:01:26Z

Actually I think we did update the library in this image: https://dl.google.com/dl/aiyprojects/vision/aiyprojects-2017-12-18.img.xz

sheridat · 2017-12-23T14:52:27Z

@drigz I zip downloaded https://github.com/drigz/aiyprojects-raspbian/tree/upgrade-assistant and copied the changed files. Then ran sudo rm -rf env followed by scripts/install-deps.sh. Version 0.1.0 of the assistant was installed.

Ran through all 3 amended assistant demo's and they all worked. Well done you.

BUT the volume of the assistant's voice is barely a whisper. On the forum we have posts from people who have upgrade to the latest version of the assistant and are reporting the same problem https://www.raspberrypi.org/forums/viewtopic.php?f=114&t=200498

I turned my volume up to max and that made the assistant voice audible - but if you run a local command the TTS volume is speaker destroying.

I will raise an issue at the assistant site and copy it through to here.

sheridat · 2017-12-23T20:08:56Z

@drigz It turns out that what you have to do is tell the assistant to turn up the volume to max by saying "Ok Google turn the volume up to maximum"

I've closed the issue I raised at the assistant repo.

sheridat · 2017-12-24T09:04:15Z

@PeterMalkin Just checked the install_deps.sh on the new image - code is

The google-assistant-library is only available on ARMv7.
if [[ "$(uname -m)" == "armv7l" ]] ; then
  env/bin/pip install google-assistant-library==0.0.3
fi

proppy · 2017-12-26T07:22:51Z

src/aiy/assistant/device_helpers.py

+
+
+def _get_model_id(credentials, session, project_id):
+    model_id = "%s-%s" % (project_id, _DEVICE_MODEL)


This was smart to concatenate project_id in there! Since the model namespace is global (not per project) this ensure there will be no conflict :)

Not especially smart, I just followed the suggestion in the docs :)

proppy · 2017-12-26T07:23:49Z

src/aiy/assistant/device_helpers.py

+    }
+    r = session.post(_get_api_url(project_id, "deviceModels"),
+                     data=json.dumps(payload))
+    if r.status_code == 409:


you shouldn't need to "update" it unless you change the list of traits (which is already empty) for this type of device.

proppy · 2017-12-26T07:25:20Z

src/aiy/assistant/device_helpers.py

+    project_id = _get_project_id()
+    model_id = model_id or _get_model_id(credentials, session, project_id)
+
+    device_id = "%s-%06d" % (model_id, random.randrange(1000000))


why not use the uuid package?

Good idea, thanks.

proppy · 2017-12-26T07:26:56Z

src/aiy/assistant/device_helpers.py

+    device_id = "%s-%06d" % (model_id, random.randrange(1000000))
+    payload = {
+            "id": device_id,
+            "model_id": model_id,


you also need to specific the client_type (SDK_LIBRARY or SDK_SERVICE):
https://developers.google.com/assistant/sdk/reference/device-registration/model-and-instance-schemas#device_instance_json

From what I see in the docs, it looks like clientType is Optional?

I've specified it as SDK_SERVICE to stay on the safe side (the assistant library will create its own device with SDK_LIBRARY).

proppy · 2017-12-26T07:27:31Z

src/assistant_library_demo.py

@@ -60,7 +61,8 @@ def process_event(event):

 def main():
    credentials = aiy.assistant.auth_helpers.get_assistant_credentials()
-    with Assistant(credentials) as assistant:
+    device_id, model_id = aiy.assistant.device_helpers.get_ids(credentials)


not that when using the google-assistant-library it generates its own ID (and you have no way to pass another one).

proppy · 2017-12-26T07:27:53Z

src/assistant_library_with_local_commands_demo.py

@@ -90,7 +91,8 @@ def process_event(assistant, event):

 def main():
    credentials = aiy.assistant.auth_helpers.get_assistant_credentials()
-    with Assistant(credentials) as assistant:
+    device_id, model_id = aiy.assistant.device_helpers.get_ids(credentials)
+    with Assistant(credentials, model_id) as assistant:


shouldn't you pass the device_id there?

Not sure what you mean - this is using the library like the other examples. I'll use the device_id once I switch to v1alpha2

proppy · 2017-12-26T07:29:58Z

@proppy, how can we specify the language? I can't see any way to specify it for the Google Assistant
Library, and the gRPC docs still say only en-US is supported.

You should be able to change the language in the "settings" of the Assistant apps, when using the gRPC API you can pass it as a field of DialogStateIn https://developers.google.com/assistant/sdk/reference/rpc/google.assistant.embedded.v1alpha2#google.assistant.embedded.v1alpha2.DialogStateIn

tei-chino · 2017-12-27T01:50:13Z

@proppy , as you said that I could not find how to to specify the language code for Google Assistant
Library in the document, the DialogStateIn is only available for Google Assistant Service, but [Release Notes] (https://developers.google.com/assistant/sdk/release-notes) said that Google Assistant Library has supported for more languages.

proppy · 2017-12-28T10:58:02Z

@tei-chino we recently published an update for the hotword sample that should allow you to set the language appropriatly.

See googlesamples/assistant-sdk-python#146 (comment) for more details. Let's move the discussion there if you encounter any other issues.

ScriptAutomate · 2018-01-02T05:09:23Z

@drigz I have also tested on an AIY Voice Kit, using your repo and upgrade-assistant branch. All of the demos work -- this includes the src/assistant_library_with_button_demo.py which does have one error when using Ctrl+c:

^CException ignored in: <module 'threading' from '/usr/lib/python3.5/threading.py'>
Traceback (most recent call last):
  File "/usr/lib/python3.5/threading.py", line 1288, in _shutdown
    t.join()
  File "/usr/lib/python3.5/threading.py", line 1054, in join
    self._wait_for_tstate_lock()
  File "/usr/lib/python3.5/threading.py", line 1070, in _wait_for_tstate_lock
    elif lock.acquire(block, timeout):
KeyboardInterrupt

This is the only error I ran into. The other example files work without issue.

Device: Pi3
OS: Raspbian Stretch

deviantony · 2018-01-02T13:30:19Z

@proppy, how can we specify the language? I can't see any way to specify it for the Google Assistant
Library, and the gRPC docs still say only en-US is supported.

You should be able to change the language in the "settings" of the Assistant apps, when using the gRPC API you can pass it as a field of DialogStateIn https://developers.google.com/assistant/sdk/reference/rpc/google.assistant.embedded.v1alpha2#google.assistant.embedded.v1alpha2.DialogStateIn

I believe that
https://github.com/google/aiyprojects-raspbian/blob/voicekit/src/aiy/_apis/_speech.py should be updated to use google.assistant.embedded.v1alpha2 instead of google.assistant.embedded.v1alpha1 in order to specify the language to use.

tei-chino · 2018-01-02T21:35:57Z

@proppy, You should be able to change the language in the "settings" of the Assistant apps, when using the gRPC API you can pass it as a field of DialogStateIn https://developers.google.com/assistant/sdk/reference/rpc/google.assistant.embedded.v1alpha2#google.assistant.embedded.v1alpha2.DialogStateIn

Thank for your information. I will invest that do see if it is possible to specify the language for aiy code. Would you like tell me it is any planning to update aiy code to specify the language.

tei-chino · 2018-01-02T21:37:03Z

@deviantony I believe that
https://github.com/google/aiyprojects-raspbian/blob/voicekit/src/aiy/_apis/_speech.py should be updated to use google.assistant.embedded.v1alpha2 instead of google.assistant.embedded.v1alpha1 in order to specify the language to use.

I think the _speech.py only can speak diffirent languages, we want to the Assistant to understand different language. This is a new function of v1alpha2, but the aiyprojects-raspbian project have not been updated yet to support that.

deviantony · 2018-01-02T21:41:57Z

@tei-chino I'm talking about the AssistantSpeechRequest class (https://github.com/google/aiyprojects-raspbian/blob/voicekit/src/aiy/_apis/_speech.py#L359) which I believe is related to Google Assistant.

I think that https://developers.google.com/assistant/sdk/reference/rpc/google.assistant.embedded.v1alpha2#google.assistant.embedded.v1alpha2.DialogStateIn is related to the user request, so that would be where to specify the language used by the user to interact with the assistant.

I'm pretty new to the codebase so I might be wrong tho.

EDIT: As stated by OP

This doesn't update from v1alpha1 of the gRPC API to v1alpha2

So probably not the good place to discuss this.

Also, swap the ID order in the demos (as it was wrong) and import the right requests package rather than relying on other modules to import it.

Update to google-assistant-{library,grpc}==0.1.0

1894ea4

This doesn't update from v1alpha1 of the gRPC API to v1alpha2, which is to follow.

drigz requested a review from proppy December 22, 2017 17:40

googlebot added the cla: yes label Dec 22, 2017

sheridat mentioned this pull request Dec 23, 2017

AIY - Voicekit- Assistant version 0.1.0 volume is less than a whisper googlesamples/assistant-sdk-python#145

Closed

proppy reviewed Dec 26, 2017

View reviewed changes

drigz mentioned this pull request Jan 3, 2018

grpc Demo not working #216

Closed

Address proppy's review feedback

f4cadff

Also, swap the ID order in the demos (as it was wrong) and import the right requests package rather than relying on other modules to import it.

drigz merged commit 75d3ceb into google:voicekit Jan 4, 2018

sheridat mentioned this pull request Jan 4, 2018

Voicekit branch - Trivial - Assistant demo's reference 0.0.2 rather than 0.1.0 #236

Closed

drigz mentioned this pull request Jan 9, 2018

Conflicting Dependencies #250

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to google-assistant-{library,grpc}==0.1.0 #207

Update to google-assistant-{library,grpc}==0.1.0 #207

drigz commented Dec 22, 2017

PeterMalkin commented Dec 22, 2017

sheridat commented Dec 23, 2017 •

edited

Loading

sheridat commented Dec 23, 2017

sheridat commented Dec 24, 2017 •

edited

Loading

proppy Dec 26, 2017

drigz Jan 4, 2018

proppy Dec 26, 2017

drigz Jan 4, 2018

proppy Dec 26, 2017

drigz Jan 4, 2018

proppy Dec 26, 2017

ScriptAutomate Jan 2, 2018

drigz Jan 4, 2018

proppy Dec 26, 2017

proppy Dec 26, 2017

drigz Jan 4, 2018

proppy commented Dec 26, 2017

tei-chino commented Dec 27, 2017

proppy commented Dec 28, 2017

ScriptAutomate commented Jan 2, 2018

deviantony commented Jan 2, 2018

tei-chino commented Jan 2, 2018

tei-chino commented Jan 2, 2018

deviantony commented Jan 2, 2018 •

edited

Loading



		def _get_model_id(credentials, session, project_id):
		model_id = "%s-%s" % (project_id, _DEVICE_MODEL)

Update to google-assistant-{library,grpc}==0.1.0 #207

Update to google-assistant-{library,grpc}==0.1.0 #207

Conversation

drigz commented Dec 22, 2017

PeterMalkin commented Dec 22, 2017

sheridat commented Dec 23, 2017 • edited Loading

sheridat commented Dec 23, 2017

sheridat commented Dec 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

proppy commented Dec 26, 2017

tei-chino commented Dec 27, 2017

proppy commented Dec 28, 2017

ScriptAutomate commented Jan 2, 2018

deviantony commented Jan 2, 2018

tei-chino commented Jan 2, 2018

tei-chino commented Jan 2, 2018

deviantony commented Jan 2, 2018 • edited Loading

sheridat commented Dec 23, 2017 •

edited

Loading

sheridat commented Dec 24, 2017 •

edited

Loading

deviantony commented Jan 2, 2018 •

edited

Loading