Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

add immediate option for cloudspeech recognize #234

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

rkkautsar
Copy link
Contributor

Closes #200

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@rkkautsar
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 4, 2018
Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

Does it work for your conversation use case? Maybe you could post your code or a link on the issue so others who find it can take advantage.

@@ -47,7 +47,9 @@ def recognize(self):
self._request.set_endpointer_cb(self._endpointer_callback)
self._recorder.add_processor(self._request)
text = self._request.do_request().transcript
if self._hotwords and text:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for immediate above, eg:

Args:
    immediate: ignore the hotword list, even if it has been populated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I place the example in the function documentation too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, hopefully people who need it can find it there :)

@drigz drigz merged commit ef8d3c9 into google:voicekit Jan 4, 2018
drigz pushed a commit that referenced this pull request Jan 4, 2018
* add immediate option for cloudspeech recognize

* add documentation for immediate argument
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants