-
Notifications
You must be signed in to change notification settings - Fork 694
add immediate option for cloudspeech recognize #234
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
Does it work for your conversation use case? Maybe you could post your code or a link on the issue so others who find it can take advantage.
@@ -47,7 +47,9 @@ def recognize(self): | |||
self._request.set_endpointer_cb(self._endpointer_callback) | |||
self._recorder.add_processor(self._request) | |||
text = self._request.do_request().transcript | |||
if self._hotwords and text: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation for immediate
above, eg:
Args:
immediate: ignore the hotword list, even if it has been populated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I place the example in the function documentation too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, hopefully people who need it can find it there :)
* add immediate option for cloudspeech recognize * add documentation for immediate argument
Closes #200