This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Fixed auth_helpers.py to work with Python 3.7 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daOrangePeeler
force-pushed
the
aiyprojects
branch
2 times, most recently
from
3e249cb
to
c0d3a38
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the web browser doesn't open properly because of improper syntax for Python 3.7. The improper call of webbrowser.register in auth_helpers.py causes the entire authentication to fail, which prevents the user from starting any of the example programs. This only happens when the user tries to authenticate using the desktop interface. When the user uses ssh, the problem is avoided.
The change in auth_helpers.py is on line 75 and the last argument is changed from "-1" to "preferred=True." The documentation explains that the last argument takes boolean values instead of numeric values. This comment also explains how to implement the fix.
Resolves #658.