-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boot device for presubmit testing #463
Conversation
187005a
to
b4abe4b
Compare
ls -l /dev/"${d}" | ||
sudo chmod a+rw /dev/"${d}" | ||
done | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary with sudo -u testrunner "${TOOL_DIR}/runtests.sh" ...
in the presubmit.sh
script?
The other tests no longer validate the group permissions are correct if everything can access these devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed without it. Those devices are owned by root:root, I either had to change the group or give permissions to all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be because the new udev rules defined in our debian packages haven't been applied so they don't trigger on the new /dev
files introduced by installing the kernel modules.
Does refreshing the udev rules help with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried that and it still fails with
0: failed to open virtual socket device /dev/vhost-vsock
1: Permission denied (os error 13)
26aeb95
to
06aa798
Compare
The meson version in ubuntu20.04 doesn't have the compile subcommand, it expects instead for the builder (ninja) to be called directly.
includes testing aosp-main phone x86_64
Fetches from android build api with
cvd fetch
Launches devices with
launch_cvd
(cvd start coming soon).Tests only aosp-main/aosp_cf_x86_64_phone-trunk_staging-userdebug for now.