Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot device for presubmit testing #463

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Boot device for presubmit testing #463

merged 3 commits into from
Mar 7, 2024

Conversation

jemoreira
Copy link
Member

Fetches from android build api with cvd fetch

Launches devices with launch_cvd (cvd start coming soon).

Tests only aosp-main/aosp_cf_x86_64_phone-trunk_staging-userdebug for now.

ls -l /dev/"${d}"
sudo chmod a+rw /dev/"${d}"
done
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary with sudo -u testrunner "${TOOL_DIR}/runtests.sh" ... in the presubmit.sh script?

The other tests no longer validate the group permissions are correct if everything can access these devices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed without it. Those devices are owned by root:root, I either had to change the group or give permissions to all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be because the new udev rules defined in our debian packages haven't been applied so they don't trigger on the new /dev files introduced by installing the kernel modules.

Does refreshing the udev rules help with this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that and it still fails with

0: failed to open virtual socket device /dev/vhost-vsock
1: Permission denied (os error 13)

.kokoro/prepare_host.sh Show resolved Hide resolved
e2etests/boot_tests.bzl Outdated Show resolved Hide resolved
e2etests/launch_cvd_boot_test.sh Outdated Show resolved Hide resolved
@jemoreira jemoreira force-pushed the main branch 3 times, most recently from 26aeb95 to 06aa798 Compare March 7, 2024 01:37
The meson version in ubuntu20.04 doesn't have the compile subcommand, it
expects instead for the builder (ninja) to be called directly.
includes testing aosp-main phone x86_64
@jemoreira jemoreira merged commit 26a1cb6 into google:main Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants