Set lengthier timeout for CVD creation under Docker #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikicha
approved these changes
Mar 15, 2024
|
b/317170946 for the context |
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
jemoreira
reviewed
Mar 15, 2024
jemoreira
reviewed
Mar 18, 2024
frontend/debian/cuttlefish-orchestration.cuttlefish-host_orchestrator.default
Outdated
Show resolved
Hide resolved
jemoreira
approved these changes
Mar 19, 2024
|
The failing test is unrelated to your code, I will update the branch (so that a change with a larger timeout applies) and re-run it, if it fails again just push it bypassing the test. |
ser-io
reviewed
Mar 19, 2024
frontend/debian/cuttlefish-orchestration.cuttlefish-host_orchestrator.default
Outdated
Show resolved
Hide resolved
ser-io
requested changes
Mar 19, 2024
0405ysj
requested changes
Mar 20, 2024
frontend/debian/cuttlefish-orchestration.cuttlefish-host_orchestrator.init
Outdated
Show resolved
Hide resolved
| @@ -24,6 +24,10 @@ orchestrator_https_port=2443 | |||
| # Defaults to "/tmp/<uid>/cvd_artifacts" | |||
| orchestrator_cvd_artifacts_dir=/var/lib/cuttlefish-common | |||
| # | |||
| # Timeout for CVD creation | |||
| # Defaults to 7 mins | |||
| orchestrator_cvd_creation_timeout=7 | |||
There was a problem hiding this comment.
Should this line be uncommented? I think there's a default value in golang code.
There was a problem hiding this comment.
Changed to comment and also changed value of the variable.
0405ysj
approved these changes
Mar 20, 2024
ser-io
approved these changes
Mar 20, 2024
Running CVD under docker can take much longer time to complete creation. To prevent CVD instance being killed by host orchestrator while booting instance, set lengthier timeout for CVD creation.
…imeout Change docker specific CVD creation timeout configuration to generic CVD with 7 mins default, and change the configuration for docker to 30 mins.
To be more clear for the timeout value of CVD creation, change unit to seconds and specified the unit at names.
Change orchestrator_cvd_creation_timeout_secs to comment and orchestrator will use golang default value for this. This simplifies making custom option for specific environment. Change Dockerfile to use echo command to apply orchestrator_cvd_creation_timeout_secs
ikicha
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running CVD under docker can take much longer time to complete creation. To prevent CVD instance being killed by host orchestrator while booting instance, set lengthier timeout for CVD creation.