Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set umask to 0 while creating directory at untar #486

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

k311093
Copy link
Collaborator

@k311093 k311093 commented Mar 26, 2024

While creating a directory at untarring artifacts, there is a possibility to create a directory not with permissions 0774.

This causes _cvd-executor failing to create a lock file for an image and then fails to execute cvd.

Set umask 0 while creating directory at untarring to create directory with proper permissions.

@k311093 k311093 requested review from ikicha and 0405ysj March 26, 2024 06:51
@k311093 k311093 added the kokoro:run Run e2e tests. label Mar 26, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 26, 2024
@k311093 k311093 added the kokoro:run Run e2e tests. label Mar 26, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 26, 2024
@k311093 k311093 added the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 26, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 26, 2024
@k311093 k311093 added the kokoro:run Run e2e tests. label Mar 26, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 26, 2024
@k311093 k311093 requested a review from 0405ysj March 26, 2024 08:30
@k311093 k311093 added the kokoro:run Run e2e tests. label Mar 26, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 26, 2024
Copy link
Member

@ser-io ser-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's squash all these commits into one for this PR.

this way we avoid having the defer issue introduced in 0d2aa01 (fixed later at d9bd9a7) in our history.

While creating a directory at untarring artifacts, there is a
possibility to create a directory not with permissions 0774.

This causes _cvd-executor failing to create a lock file for an image
and then fails to execute cvd.

Set umask 0 while creating directory at untarring to create directory
with proper permissions.
@k311093
Copy link
Collaborator Author

k311093 commented Mar 27, 2024

Squashed all commits into one

@k311093 k311093 requested a review from ser-io March 27, 2024 00:54
@k311093 k311093 added the kokoro:run Run e2e tests. label Mar 27, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 27, 2024
@k311093 k311093 added the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 27, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 27, 2024
@k311093 k311093 merged commit 0b8b2a9 into google:main Mar 27, 2024
5 checks passed
@k311093 k311093 deleted the umask_tar branch March 27, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants