-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set umask to 0 while creating directory at untar #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Trigger a presubmit build unconditionally.
label
Mar 26, 2024
0405ysj
requested changes
Mar 26, 2024
ikicha
approved these changes
Mar 26, 2024
0405ysj
approved these changes
Mar 26, 2024
ser-io
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While creating a directory at untarring artifacts, there is a possibility to create a directory not with permissions 0774. This causes _cvd-executor failing to create a lock file for an image and then fails to execute cvd. Set umask 0 while creating directory at untarring to create directory with proper permissions.
Squashed all commits into one |
ikicha
approved these changes
Mar 27, 2024
ser-io
approved these changes
Mar 27, 2024
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Trigger a presubmit build unconditionally.
label
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a directory at untarring artifacts, there is a possibility to create a directory not with permissions 0774.
This causes _cvd-executor failing to create a lock file for an image and then fails to execute cvd.
Set umask 0 while creating directory at untarring to create directory with proper permissions.