Moved new Debian host image project from codelinaro to Cuttlefish github #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause new kernel may not work with new iptables tool.
…d use this var to detect if it is inside the docker container.
Removed the ENV method, instead, by touch /.dockerenv file to make sure this file always exist.
Removed the ENV method, instead, by touch /.dockerenv file to make sure this file always exist.
Removed the ENV method, instead, by touch /.dockerenv file to make sure this file always exist.
WeiChungHsu
requested review from
Databean,
jemoreira,
rmuthiah,
jmacnak and
adelva1984
as code owners
heyuchen
reviewed
Apr 1, 2024
| @@ -0,0 +1,55 @@ | |||
| # Gigabyte Ampere Cuttlefish Installer | |||
There was a problem hiding this comment.
Could we change it to a more universal name since it's not exclusive to Gigabyte?
There was a problem hiding this comment.
same for the project directory name
There was a problem hiding this comment.
Changed to cuttlefish-host-image-installer.
…me .gitlab-ci.yml can't be committed into github.
… is a generic installer and should work on most of hardware/host, not just Gigabyte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved new Debian host image project from codelinaro to Cuttlefish github. Not fully ready yet. Need more time to make CI and yaml/yml working.