Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore errors in unit tests. #499

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Do not ignore errors in unit tests. #499

merged 1 commit into from
Apr 4, 2024

Conversation

ser-io
Copy link
Member

@ser-io ser-io commented Apr 4, 2024

  • Ignoring errors leads to unexpected behaviors and misleading error messages.

@ser-io
Do not ignore errors in unit tests.
cde686d 
- Ignoring errors leads to unexpected behaviors and misleading error
  messages.
@ser-io ser-io requested a review from jemoreira as a code owner April 4, 2024 18:57
@ser-io ser-io mentioned this pull request Apr 4, 2024
Merged
@ser-io ser-io merged commit 1864344 into google:main Apr 4, 2024
5 checks passed
@ser-io ser-io deleted the fix-unit-test branch April 10, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemoreira jemoreira jemoreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ser-io @jemoreira