cvd cache #834
Draft
cvd cache #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
cvd_cache
branch
6 times, most recently
from
a3611b0 to
c40ba5b
Compare
`ParseInt` was failing on the output of `du` because it is in a format like: "<total num> <filepath>". This version splits that and takes the first portion. We should update this later to not rely on `du`, b/385384942 should encompass that. Returning to the `atoi` implementation was not a good idea for the bytes version, because it was still susceptible to overflow issues. Changed the return value to be a `size_t` instead of a signed number, because the sizes will not (should not?) ever be negative. Added a `GflagsCompatFlag` overload for reading in flags that can be compared to the output of this helper. The `GetDiskUsageGigabytes` will still be used in the upcomign `cvd cache`, while the `*Bytes` version will be used when we sync these changes back to AOSP. Test: use the `cvd_cache` branch and run `cvd cache size`
The manual managing leaves more opportunity for a mistake or error to cause the previous logger to never be reset. Also, for tee logging we always wanted to set the Android LogSeverity to `VERBOSE` because the levels are managed internal to those loggers. This is automatically handled as well, which is why the `ScopedLogSeverity` is a member instead of being instantiated alongside the logger. The new `LogToStderr` (and `ScopedTeeLogger`) will be used in the upcoming `cvd cache`, because it will eventually be called from `cvd fetch` invocations. Test: TBD, I think a `cvd load` call will have successive logger setups?
cjreynol
force-pushed
the
cvd_cache
branch
2 times, most recently
from
a7ab027 to
ada20c8
Compare
New command used to manage the local fetch cache. Will eventually be automatically invoked during every `cvd fetch` call to keep the cache from growing without end. Bug: 384803921 Test: cvd help # see summary help Test: cvd help cache Test: cvd cache Test: cvd cache where Test: cvd cache size Test: cvd cache empty Test: cvd cache cleanup Test: cvd cache cleanup --allowed_size_GB=<`cvd cache size` - 1> Test: cvd cache cleanup --allowed_size_GB=-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be squashed and split into a few PRs:
GetDiskUsagefix and new unsigned flag parser overloadScopedTeeLoggerand its application tofetch_cvd.cccvd cachecommand