Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Success during upload results in lost updates to the db. #2408

Closed
aditya-07 opened this issue Jan 11, 2024 · 2 comments
Closed

Partial Success during upload results in lost updates to the db. #2408

aditya-07 opened this issue Jan 11, 2024 · 2 comments
Assignees
Labels
P1 High priority issue type:bug Something isn't working

Comments

@aditya-07
Copy link
Collaborator

Describe the bug
In the current uploader, if more than one requests is sent to the server and the last request fails, the success of the previous requests is ignored. This results in the DB not getting the updated values from the server and local changes still persist even though they have been successfully uploaded.

Component
Core library

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@jingtang10
Copy link
Collaborator

is this fixed by #2392?

@MJ1998 @aditya-07

@aditya-07
Copy link
Collaborator Author

@jingtang10 Yes, it is fixed by #2392. So closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:bug Something isn't working
Projects
Status: Complete
Development

No branches or pull requests

5 participants