Restore Granular Upload Progress Updates and Database Consolidation #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ1998
changed the title
MJ1998
changed the title
aditya-07
reviewed
Jan 31, 2024
engine/src/main/java/com/google/android/fhir/sync/upload/request/UploadRequestGenerator.kt
Show resolved
Hide resolved
aditya-07
reviewed
Feb 1, 2024
demo/src/main/java/com/google/android/fhir/demo/data/DemoFhirSyncWorker.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/sync/upload/UploaderTest.kt
Show resolved
Hide resolved
This was referenced Feb 1, 2024
jingtang10
reviewed
Feb 2, 2024
demo/src/main/java/com/google/android/fhir/demo/data/DemoFhirSyncWorker.kt
Show resolved
Hide resolved
sharon2719
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Feb 6, 2024
…oogle#2392) * Upload giving intermediate progresses * emit uploadresults until its a Failure * tests * add test to verify multiple results emit * extra code * fix test issue * update merge * resolve comments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2355 #2408
Description
syncUpload's upload lambda changed from
upload: (suspend (List<LocalChange>) -> UploadSyncResult)TOupload: (suspend (List<LocalChange>) -> Flow<UploadRequestResult>)Removed
UploadSyncResultas its not needed anymore.Uploader.upload returns a Flow
Modified UploadRequestResult.Failure to have information about localChanges.
Added bundleSize as a config parameter to
UploadRequestGeneratorMode.BundleRequestto test with bundleSize = 1Added test case to check flow of multiple results being returned.
Alternative(s) considered
Alternative was to solve for #2408 only by returning partial successes also in the consolidated
UploadSyncResultin case there is a failure. This is developer-convenient as it does not require much change but does not solve both the issues. Also, we anticipate changing this API (in fact potentially moving this API completely) and minimal change could be preferred. However, with a little developer pain we can solve both the issues. Discussed with @aditya-07.Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.