-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for the data capture codelab #1436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads really well!
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
=========================================
Coverage 85.68% 85.68%
Complexity 716 716
=========================================
Files 149 149
Lines 10768 10768
Branches 860 860
=========================================
Hits 9227 9227
Misses 1100 1100
Partials 441 441 Continue to review full report at Codecov.
|
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Thanks both @omarismail94 and @williamito - ptal! |
LGTM. |
@williamito this should be fixable - can you try following the details of the failed check, it'll lead you to a page with a link to sign the cla using your personal email. thanks! |
1 similar comment
@williamito this should be fixable - can you try following the details of the failed check, it'll lead you to a page with a link to sign the cla using your personal email. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @jingtang10 ! Had more time today to look in more detail and left a few more comments :)
@omarismail94 by the way this is all @williamito 's work. he did all the writing. all credits to him. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Update README.md for the data capture codelab
Alternative(s) considered
NA
Type
Documentation
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.