-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make multi-line text widget taller by default #1517
Conversation
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemEditTextViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do other 2 files shows code formatting changes?
LGTM, Thanks!
i think probably other prs didn't run spotless properly? i'm not entirely sure |
style="?attr/questionnaireTextInputEditTextStyle" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:gravity="top" | ||
android:minLines="3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this change allow the developer application to change the minLines ? Maybe minLines should be part of a new multi-line text style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aditya-07 - i think this should be probably done as a follow-up. We haven't heard any feature request about this one from the developers. Feel like this is a weaker requirement compared with what we still have to do to allow custom styles.
@santosh-pingle fyi @shelaghm fyi
@jingtang10 this looks good to me. It aligns with what I was thinking for paragraph text style.
|
Do you mean change the widget's name to As an engineer, I sort of prefer the more functional names i.e. But I do understand why semantically it might be easier for people to understand what these means... so I'm ok with
they are already separate components. but we're not showcasing them in the catalog app yet. i think the question here is wheather we put them in one single component or seprarate as two? both ok with me. single's probably fine and we can use the bottom sheet to toggle single/multi line?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1197
Description
Set a minimum number of lines for the multi-line edit text widget.
The widet will initially have 3 lines to indicate that the widget itself supports multi-line input. But as the user types the widget would expand vertically to accommodate more lines.
Alternative(s) considered
NA
Type
Bug fix
Screenshots (if applicable)
multiline.mp4
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.