-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply separate style to question text if type is group. #1546
Merged
santosh-pingle
merged 8 commits into
google:master
from
santosh-pingle:sp/issue-1450-instructions
Aug 26, 2022
Merged
Apply separate style to question text if type is group. #1546
santosh-pingle
merged 8 commits into
google:master
from
santosh-pingle:sp/issue-1450-instructions
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
approved these changes
Aug 18, 2022
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Aug 19, 2022
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Aug 25, 2022
jingtang10
approved these changes
Aug 25, 2022
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1450
Description
Earlier, it was okay to have single attribute resource to set style to question text in header view in all views, but now requirement is to set different style to question text if type is group. Therefore we can not keep same existing files and set attribute resource at run time in kolin code according to the group type, as there is no such api which which accepts attribute resource.
So created separate xml resource file for group type header view and updated changes accordingly.
Alternative(s) considered
Another approach is to set attribute resource to question text if type is group in header view in kotlin code, but there is no such api which accept attribute as resource to set the style.
Type
![Screen Shot 2022-08-09 at 4 28 55 PM](https://user-images.githubusercontent.com/86107848/183632381-b844244a-bc24-4100-835d-aaa0ee3947bb.png)
Choose one: Feature
Screenshots (if applicable)
Attaching screenshot for demo purpose only.
@shelaghm
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.