-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate the initial value using the initial expression extension for reference type #1831
Conversation
* Added custom search paramter. * Review changes : Injecting ResourceIndexer into ResourceDao
* Show submit button in review mode * Added tests * Review comments: Updated the fragment result listener to check explicit result values
* Fix for removing old indexes when resource is updated * Added comments
Codecov Report
@@ Coverage Diff @@
## master #1831 +/- ##
=============================================
+ Coverage 0 43.49% +43.49%
- Complexity 0 409 +409
=============================================
Files 0 160 +160
Lines 0 6005 +6005
Branches 0 1132 +1132
=============================================
+ Hits 0 2612 +2612
- Misses 0 2935 +2935
- Partials 0 458 +458
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment, should we use the question type as an input when we set initial answers?
For example, IdType
may be converted to either a string, or a reference, depending on the question item type. Is this something that's specified in FHIR? Is there a fixed list of allowed mappings? Or is this something we just want to do in our code.
@omarismail94 I managed to test the PR, but I found an issue where the initial expression value is not being set. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1830
Description
When the Questionnaire Type is a Reference, but contains an initial expression extension that returns an ID, make this ID a reference type so that it can be displayed
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
No
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.