-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questionnaire Fragment: Added extra to show or hide submit button. #1846
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
=============================================
+ Coverage 0 43.55% +43.55%
- Complexity 0 407 +407
=============================================
Files 0 160 +160
Lines 0 5990 +5990
Branches 0 1129 +1129
=============================================
+ Hits 0 2609 +2609
- Misses 0 2923 +2923
- Partials 0 458 +458
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Aditya! Do we need to update any themes to remove the "submit" funcitonality? Im thinking XML files, configs, etc
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change Aditya!
FYI @jingtang10: Im approving this!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1845
Description
Added
EXTRA_SHOW_SUBMIT_BUTTON
to show or hide submit button in aQuestionnaireFragment
. Default isTrue
(show).Also, removed any dependence on
Questionnaire.SubmitButtonStyle
to show or hide submit button in aQuestionnaireFragment
.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.