Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make boolean type options full screen width while horizont… #1985

Merged
merged 4 commits into from
May 13, 2023
Merged

Changes to make boolean type options full screen width while horizont… #1985

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e53c14d
Changes to make boolean type options full screen width while horizont…
khyativyasargus Apr 24, 2023
ae00170
Apply suggestions from code review
khyativyasargus Apr 27, 2023
6cbc855
Merge branch 'master' into 1968-make-boolean-type_options-full-screen…
jingtang10 May 3, 2023
e94abe0
Merge branch 'master' into 1968-make-boolean-type_options-full-screen…
jingtang10 May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ava/com/google/android/fhir/datacapture/views/factories/BooleanChoiceViewHolderFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package com.google.android.fhir.datacapture.views.factories

import android.view.View
import android.view.ViewGroup
import android.widget.LinearLayout
import android.widget.RadioButton
import androidx.constraintlayout.helper.widget.Flow
import androidx.constraintlayout.widget.ConstraintLayout
Expand Down Expand Up @@ -133,12 +134,13 @@ internal object BooleanChoiceViewHolderFactory :
choiceOrientation: ChoiceOrientationTypes
) {
layoutParams =
ViewGroup.LayoutParams(
LinearLayout.LayoutParams(
when (choiceOrientation) {
ChoiceOrientationTypes.HORIZONTAL -> ViewGroup.LayoutParams.WRAP_CONTENT
ChoiceOrientationTypes.HORIZONTAL -> 0
khyativyasargus marked this conversation as resolved.
Show resolved Hide resolved
ChoiceOrientationTypes.VERTICAL -> ViewGroup.LayoutParams.MATCH_PARENT
},
ViewGroup.LayoutParams.WRAP_CONTENT
ViewGroup.LayoutParams.WRAP_CONTENT,
1.0f
khyativyasargus marked this conversation as resolved.
Show resolved Hide resolved
)
}

Expand Down