-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update padding for the helper icon. #2106
Update padding for the helper icon. #2106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the help icon is 48x48px... but i don't understand why it's more cropped given the height and width are 24dp. does this mean android is automatically scaling the image? and if so, why isn't it scaled perfectly since 48x48 and 24x24 are both perfectly square? what's causing the crop on the right?
can you update the xml file itself to see a 24x24 icon would work better?
by changing the size to 28 we're making the row taller, right?
Done. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2093
Description
Default padding of icon in TextButton was pushing icon to the right end, as result icon appeared as cut on right side.
Default padding is overridden so that it will not pushed to the right side.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.