Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Uploading Individual requests - Not exposed yet #2121

Merged
merged 12 commits into from
Aug 22, 2023
Merged

Support Uploading Individual requests - Not exposed yet #2121

merged 12 commits into from
Aug 22, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Aug 8, 2023 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2110 #2112

Description
Clear and concise code change description.

Support uploading individual upload requests to the server:

  • Add endpoints for individual PUT, DELETE, and PATCH requests
  • Wrote an individual request generator
  • Refactored TransactionBundleGenerator to follow how the IndividualRequestGenerator is written as it's easier to add support for different create/update mappings
  • Added unit tests for FhirHttpDataSource class
  • Tested creating and updating on HAPI FHIR server using individual requests and it worked

Note: This is not exposed yet for use. TransactionBundleGenerator is currently hardcoded for use int he SquashChangesUploadManager. IndividualRequestGenerator to be exposed in a follow-up PR as part of the upload re-design

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 changed the title Create IndividualRequestGenerator Support Uploading Individual requests Aug 11, 2023
@omarismail94 omarismail94 marked this pull request as ready for review August 11, 2023 13:48
@omarismail94 omarismail94 requested review from santosh-pingle and a team as code owners August 11, 2023 13:48
@omarismail94 omarismail94 requested a review from aditya-07 August 11, 2023 13:48
@jingtang10 jingtang10 self-assigned this Aug 21, 2023
jingtang10
jingtang10 requested changes Aug 21, 2023
View reviewed changes
engine/src/test/java/com/google/android/fhir/sync/upload/IndividualGeneratorTest.kt Show resolved Hide resolved
engine/src/test/java/com/google/android/fhir/sync/upload/IndividualGeneratorTest.kt Outdated Show resolved Hide resolved
engine/src/test/java/com/google/android/fhir/sync/upload/IndividualGeneratorTest.kt Outdated Show resolved Hide resolved
engine/src/test/java/com/google/android/fhir/sync/upload/IndividualGeneratorTest.kt Outdated Show resolved Hide resolved
engine/src/test/java/com/google/android/fhir/sync/upload/IndividualGeneratorTest.kt Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/IndividualRequestGenerator.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/IndividualRequestGenerator.kt Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/Request.kt Show resolved Hide resolved
jingtang10
jingtang10 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What's IRG in the description? Is it IG?
  2. This is not wired up yet right? can you make this clear in the PR name and description?

engine/src/main/java/com/google/android/fhir/sync/upload/IndividualRequestGenerator.kt Outdated Show resolved Hide resolved
@omarismail94 omarismail94 mentioned this pull request Aug 22, 2023
Open
@omarismail94 omarismail94 changed the title Support Uploading Individual requests Support Uploading Individual requests - Not exposed yet Aug 22, 2023
@omarismail94
Copy link
Contributor Author

@jingtang10

For 1, IRG Is IndividualRequestGenerator. I replace the acronym with the full name in the description.
For 2, done!

  1. What's IRG in the description? Is it IG?
  2. This is not wired up yet right? can you make this clear in the PR name and description?

@omarismail94 omarismail94 enabled auto-merge (squash) August 22, 2023 09:27
@omarismail94 omarismail94 merged commit f71dab6 into google:master Aug 22, 2023
@omarismail94 omarismail94 deleted the postit branch August 22, 2023 10:40
This was linked to issues Sep 14, 2023
Create new resources on the server using POST #760
Closed
Upload Work Manager - API refactoring #2103
Closed
@jingtang10 jingtang10 mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@aditya-07 aditya-07 Awaiting requested review from aditya-07 aditya-07 was automatically assigned from google/android-fhir

Assignees

@jingtang10 jingtang10

Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
3 participants
@omarismail94 @jingtang10 @android-fhir-bot