Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'system' in evaluation of unique Coding identifierString #2148

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Aug 29, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2136

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS requested review from santosh-pingle and a team as code owners August 29, 2023 21:53
@LZRS LZRS requested a review from jingtang10 August 29, 2023 21:53
@LZRS LZRS force-pushed the 2136-fix-coding-identity branch 4 times, most recently from 106677a to c4d7e8f Compare August 31, 2023 12:56
@LZRS LZRS force-pushed the 2136-fix-coding-identity branch from c4d7e8f to f46b9e6 Compare September 1, 2023 08:16
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @LZRS! 👍👍👍

@jingtang10 jingtang10 enabled auto-merge (squash) September 1, 2023 15:21
@jingtang10 jingtang10 merged commit 4681561 into google:master Sep 5, 2023
@jingtang10 jingtang10 deleted the 2136-fix-coding-identity branch September 5, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
3 participants