Allow sorting in [rev]include results. #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested changes
Oct 3, 2023
demo/src/main/java/com/google/android/fhir/demo/FhirApplication.kt
Outdated
Show resolved
Hide resolved
…o, supressing it as couldn't find a workaround for the api
jingtang10
requested changes
Dec 12, 2023
engine/src/main/java/com/google/android/fhir/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/search/SearchTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/search/SearchTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/search/SearchTest.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/dao/ResourceDao.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/dao/ResourceDao.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/dao/ResourceDao.kt
Outdated
Show resolved
Hide resolved
engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt
Outdated
Show resolved
Hide resolved
…for forward and rev include
…tUUIDToByte from androidx.room package. So, supressing it as couldn't find a workaround for the api
jingtang10
approved these changes
Dec 18, 2023
MJ1998
reviewed
Dec 19, 2023
hugomilosz
pushed a commit
to hugomilosz/android-fhir
that referenced
this pull request
Jan 17, 2024
* Allow sorting in [rev]include results * Review comment changes * Fixed failing tests * Lint fails build because of the use of restricted api from package. So, supressing it as couldn't find a workaround for the api * Spotless * Updated failing test * Review comments: Fixed tests * Review comments: Refactored db code to separate out search functions for forward and rev include * Lint fails build because of the use of restricted api UUIDUtil.convertUUIDToByte from androidx.room package. So, supressing it as couldn't find a workaround for the api * Review Comments: Unified the usage of getSortOrder * Review comments: Updated kdoc
sharon2719
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Feb 6, 2024
* Allow sorting in [rev]include results * Review comment changes * Fixed failing tests * Lint fails build because of the use of restricted api from package. So, supressing it as couldn't find a workaround for the api * Spotless * Updated failing test * Review comments: Fixed tests * Review comments: Refactored db code to separate out search functions for forward and rev include * Lint fails build because of the use of restricted api UUIDUtil.convertUUIDToByte from androidx.room package. So, supressing it as couldn't find a workaround for the api * Review Comments: Unified the usage of getSortOrder * Review comments: Updated kdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2378
Description
Allow developers to return sorted results of [rev]include search block.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.