Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide previous and next button #2397

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Hide previous and next button #2397

merged 5 commits into from
Jan 23, 2024

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Jan 2, 2024 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2394

Description

  1. Hide the previous button when in the first page
  2. Hide the next button when in the last page

Alternative(s) considered
N/A

Type
Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@FikriMilano FikriMilano requested review from santosh-pingle and a team as code owners January 2, 2024 04:02
@FikriMilano FikriMilano requested a review from ktarasenko January 2, 2024 04:02
@FikriMilano
Copy link
Collaborator Author

this is ready for review

This was referenced Jan 10, 2024
Closed
Merged
@jingtang10
Copy link
Collaborator

as discussed in emails, we'll just hide by default in these cases. please update the pr fikri - thanks!

@FikriMilano FikriMilano changed the title Configure prev and next button when disabled Hide previous and next button Jan 18, 2024
@FikriMilano FikriMilano force-pushed the 2394-configure-prev-next-button-when-disabled branch from fc8b159 to cafd4db Compare January 18, 2024 07:52
@FikriMilano
Copy link
Collaborator Author

@jingtang10 this PR is ready for review

@jingtang10 jingtang10 enabled auto-merge (squash) January 23, 2024 10:59
@jingtang10 jingtang10 merged commit 99c5b9c into google:master Jan 23, 2024
3 checks passed
@jingtang10 jingtang10 deleted the 2394-configure-prev-next-button-when-disabled branch January 23, 2024 12:14
sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
@FikriMilano @sharon2719
Hide previous and next button (google#2397)
afd1f6c 
* Hide previous button on first page

* Hide next button on last page

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@ktarasenko ktarasenko Awaiting requested review from ktarasenko ktarasenko was automatically assigned from google/android-fhir

Assignees

@aditya-07 aditya-07

Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide previous and next button
3 participants
@FikriMilano @jingtang10 @aditya-07