Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdoc for synchronize function post supporting coroutine-safety #2417

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Jan 31, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Missed adding kdoc to the synchronize function in #2385 .

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Documentation

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@MJ1998 MJ1998 requested review from santosh-pingle and a team as code owners January 31, 2024 14:12
@MJ1998 MJ1998 requested a review from elegantmush January 31, 2024 14:12
Copy link
Contributor

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MJ1998 MJ1998 mentioned this pull request Jan 31, 2024
7 tasks
@jingtang10 jingtang10 enabled auto-merge (squash) January 31, 2024 15:08
@jingtang10 jingtang10 merged commit d97031d into google:master Jan 31, 2024
3 checks passed
sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants