-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the bottom navigation container if there are no visible buttons. #2453
Conversation
Screen.Recording.2024-02-27.at.17.42.34.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @santosh-pingle for the change!
as discussed, can you please explore ways to fix this issue in the layout xml files? that would be preferred over a fix in the kotlin code - at the end of the day, i feel it's more natural for the bottom navigation to collapse organically when no button is visible inside of it - this makes our code a bit simpler.
thanks!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2446
Description
If there is no button visible in the bottom navigation container then it was overlapping review mode recyclerview, as result screen was appearing blank.
Now issue is fixed by hiding bottomNavigation container if there is no children.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.