Evaluate enable when with newly created repeated groups #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
aditya-07,
MJ1998 and
santosh-pingle
as code owners
jingtang10
changed the title
.../main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
santosh-pingle
approved these changes
Jul 4, 2024
santosh-pingle
pushed a commit
to santosh-pingle/android-fhir
that referenced
this pull request
Jul 8, 2024
* Update enablement evaluator * Add test case for calculating enable when with new repeated group * Add tests for shouldHaveNestedItemsUnderAnswers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2590
Description
Reinitialize the enablement evaluator when the questionnaire response tree changes (i.e. repeated groups or items with nested questions are added or removed). This makes sure the pre-order list and parent tree are recreated to reflect the new tree structure of the questionnaire response, and that the question referenced in the enable when can be identified correctly.
Alternative(s) considered
I asked this question in FHIR chat https://chat.fhir.org/#narrow/stream/179266-fhirpath/topic/parent.28.29.20or.20siblings.28.29.3F and Paul and Brian suggested that we could use a variable defined at the parent of the repeated group. If this works in our case still needs to be verified.
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.