Fix an issue with Python3 multipart encodings. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered in googleapis/google-cloud-python#1760, we were mangling bytes when encoding them as part of a multipart upload request. The fix is to switch from using `six.StringIO` to `six.BytesIO` in `transfer.py`. The patch here is closely based on googleapis/google-cloud-python#1779.
|
Took a look. No glaring issues. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in
googleapis/google-cloud-python#1760, we were
mangling bytes when encoding them as part of a multipart upload request. The
fix is to switch from using
six.StringIOtosix.BytesIOintransfer.py.The patch here is closely based on
googleapis/google-cloud-python#1779.
PTAL @thobrla
cc @dhermes -- Danny, if you have two minutes to take a look at the test, I would love a set of more-python3-savvy eyes. It fails before the patch and passes after, so it's definitely testing the right things, but I would be willing to believe I've managed to fool myself. 😉