Remove META-INF/*.kotlin_module entries from the AutoValue jar.
#1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
We bundle a shaded copy of `kotlinx.metadata.jvm` and related libraries, which we use to inspect Kotlin data classes. The libraries are only called from Java code, which means that `META-INF/kotlinx-metadata-jvm.kotlin_module` and the like serve no purpose, other than to confuse the Kotlin compiler when it sees these entries. Fixes #1574. RELNOTES=An "incompatible version" issue with Kotlin compilation has been fixed. See #1574. PiperOrigin-RevId: 557180357
copybara-service
bot
force-pushed
the
test_main_557180357
branch
2 times, most recently
from
3317f71
to
b21c7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
META-INF/*.kotlin_moduleentries from the AutoValue jar.We bundle a shaded copy of
kotlinx.metadata.jvmand related libraries, which we use to inspect Kotlin data classes. The libraries are only called from Java code, which means thatMETA-INF/kotlinx-metadata-jvm.kotlin_moduleand the like serve no purpose, other than to confuse the Kotlin compiler when it sees these entries.Fixes #1574.
RELNOTES=An "incompatible version" issue with Kotlin compilation has been fixed. See #1574.