Fix the logic for computing the number of int default-value bitmasks in a Kotlin constructor.
#1807
+140
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…s in a Kotlin constructor. There are ⌈_n_/32⌉ `int` bitmasks when the total number of parameters is _n_. Previously the logic was based on _n_ being the number of _optional_ parameters (the ones with default values). RELNOTES=A bug with AutoBuilder and Kotlin data classes has been fixed. If there was a mix of required and optional parameters in a data class with a large number of properties, sometimes the generated code would not compile. PiperOrigin-RevId: 651226198
copybara-service
bot
force-pushed
the
test_main_651098596
branch
from
1c0b02a
to
ad284f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic for computing the number of
intdefault-value bitmasks in a Kotlin constructor.There are ⌈n/32⌉
intbitmasks when the total number of parameters is n. Previously the logic was based on n being the number of optional parameters (the ones with default values).RELNOTES=A bug with AutoBuilder and Kotlin data classes has been fixed. If there was a mix of required and optional parameters in a data class with a large number of properties, sometimes the generated code would not compile.