Moe Sync #619
Moe Sync #619
Conversation
…nnotation processor configuration. The standalone apt plugin is now only required for use on previous versions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=190688689
| } | ||
| ``` | ||
|
|
||
| Note: If you are using a version of Gradle prior to 4.6, you must apply an | ||
| annotation processing plugin [as described in these instructions][tbroyer-apt] | ||
| and use the `apt` configuration instead of `annotationProcessor`. |
There was a problem hiding this comment.
No need to use apt; latest version of the plugin uses annotationProcessor
There was a problem hiding this comment.
Thanks, we'll delete the business of using the apt configuration.
| Note: If you are using a version of Gradle prior to 4.6, you must apply an | ||
| annotation processing plugin [as described in these instructions][tbroyer-apt] | ||
| and use the `apt` configuration instead of `annotationProcessor`. | ||
|
|
||
| [tbroyer-apt]: https://plugins.gradle.org/plugin/net.ltgt.apt |
There was a problem hiding this comment.
Link to GitHub to get the documentation? (and not just the snippet to apply it)
There was a problem hiding this comment.
There's a GitHub link right at the top of that page. Is there a link you'd rather see instead of the one here?
There was a problem hiding this comment.
I was referring to https://github.com/tbroyer/gradle-apt-plugin, or https://github.com/tbroyer/gradle-apt-plugin/blob/master/README.md (see #606 (comment))
That link doesn't itself include instructions (it defers to https://plugins.gradle.org/plugin/net.ltgt.apt) but has the documentation for the plugin, and talks about setting up your IDE, which is facilitated using other plugins. Both links reference the other, so use the one you prefer, but I've had issues reported about not seeing generated code in IDEs from people that came from the Gradle Plugin Portal and didn't click through to the README (they did find where to report the issue though, so it might be that they just didn't bother looking things up before creating an issue).
I don't have a strong opinion on that one.
…ng plugin. See #619 (review). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=191449704
…ng plugin. See #619 (review). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=191449704
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Update AutoValue's Gradle documentation to account for the built-in annotation processor configuration.
The standalone apt plugin is now only required for use on previous versions.
07426cb