Generate impl UniquePtr for abstract types too
#1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsilver8192
force-pushed
the
impl-abstract-type
branch
2 times, most recently
from
a50fc60 to
42d7d46
Compare
Similarly to non-abstract types, if one `include_cpp!` section `generate!`s an abstract type but never uses `unique_ptr` for that type, but another one does, we need the explicit `impl UniquePtr` so that cxx allows it.
bsilver8192
force-pushed
the
impl-abstract-type
branch
from
42d7d46 to
ec7a454
Compare
|
Thanks! Note to my future self: I'm going to go ahead and merge this. It makes me a little nervous since (a) I don't claim to have my head around the requirements which |
frc971-automation
pushed a commit
to frc971/971-Robot-Code
that referenced
this pull request
Aug 17, 2022
Backport of google/autocxx#1137. Change-Id: I80e69a93880adf3f907078a55fbdb4e99f15ff2b Signed-off-by: Brian Silverman <bsilver16384@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to non-abstract types, if one
include_cpp!sectiongenerate!s an abstract type but never usesunique_ptrfor that type,but another one does, we need the explicit
impl UniquePtrso that cxxallows it.