Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple AUTOCXX_RS_JSON_ARCHIVE entries #1147

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

bsilver8192
Copy link
Contributor

This is helpful when using relative paths with doctests, because
doctests are compiled from a different working directory than the crate
itself. Bazel requires relative paths in environment variables so that
caching works across machines, for example.

This is helpful when using relative paths with doctests, because
doctests are compiled from a different working directory than the crate
itself. Bazel requires relative paths in environment variables so that
caching works across machines, for example.
@bsilver8192 bsilver8192 force-pushed the multiple-json-archive-paths branch from 661300b to c3c0204 Compare August 14, 2022 20:57
@bsilver8192 bsilver8192 marked this pull request as draft August 14, 2022 20:58
@bsilver8192
Copy link
Contributor Author

This is a draft due to depending on #1148, and GitHub's lack of good support for dependent PRs. Feel free to mark as in progress (I think anybody can do that?) and merge once that's merged.

@bsilver8192 bsilver8192 marked this pull request as ready for review August 15, 2022 04:23
@adetaylor adetaylor merged commit 9d7d2cb into google:main Aug 15, 2022
@bsilver8192 bsilver8192 deleted the multiple-json-archive-paths branch August 15, 2022 08:42
frc971-automation pushed a commit to frc971/971-Robot-Code that referenced this pull request Aug 17, 2022
Backport of google/autocxx#1147.

Change-Id: I1657b15cff87110a177eecf49944eabc9b628c89
Signed-off-by: Brian Silverman <bsilver16384@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants