Add failing test for extern_rust_function #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much! If I had to guess, I'd say the problem is the |
|
Indeed, |
adetaylor
added a commit
that referenced
this pull request
Oct 17, 2022
adetaylor
added a commit
that referenced
this pull request
Oct 20, 2022
Previously extern_rust_function support was highly basic and didn't usually work at all. This change improevs matters: * it allows us to emit errors with miette diagnostics from this part of the codebase, giving spans in case of trouble * it validates that the parameters to such a function are valid to be used by cxx, as is the return type * it detects types used as parameters and return type and ensures they are not garbage collected elsewhere in autocxx * it adds a code example. * we remove a field from RustFun which we didn't actually need and replace it with a simple Boolean. Builds on test case from #1166 (thanks!) and there's a bit of discussion in #1167.
adetaylor
added a commit
that referenced
this pull request
Oct 20, 2022
Previously extern_rust_function support was highly basic and didn't usually work at all. This change improevs matters: * it allows us to emit errors with miette diagnostics from this part of the codebase, giving spans in case of trouble * it validates that the parameters to such a function are valid to be used by cxx, as is the return type * it detects types used as parameters and return type and ensures they are not garbage collected elsewhere in autocxx * it adds a code example. * we remove a field from RustFun which we didn't actually need and replace it with a simple Boolean. Builds on test case from #1166 (thanks!) and there's a bit of discussion in #1167.
|
Landed in #1168 (thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Contributing section, the best way to submit a bug is to submit a PR of a failing integration test, so, here's a minimal case from some code I've been trying to write, where a Rust function receives a C++ context, and
cxxrejects the generated code with anunsupported typeerror (lacking a span, which makes it unhelpful).