Fix namespaced destructors and reject unions #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a few issues reported in #1261 (thanks!) Specifically, * We were correctly refusing to generate POD bindings to unions, but we were rejecting them with a nonsensical error. We now reject with a specific message. * Types in namespaces sometimes had misgenerated code to call their C++ destructors. I also took the opportunity to rework CppNameMap. Issue #1261
This enables test_issue_1096c and test_type_aliased_anonymous_nested_struct_ignored to pass. It remains to be seen if this causes failures elsewhere.
adetaylor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a few issues reported in #1261 (thanks!)
Specifically,
I also took the opportunity to rework
CppNameMapslightly by making some functions members. This is primarily a textual change.Issue #1261