Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feature flag for runtime #1277

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: feature flag for runtime #1277

merged 1 commit into from
Apr 25, 2023

Conversation

gen-xu
Copy link
Contributor

@gen-xu gen-xu commented Apr 20, 2023 •
edited
Loading

Fixes #1276

explicitly specify features for autocxx-bindgen and disable default features such that the runtime is excluded from dependencies but added over the runtime features of this crate, to avoid having static feature flag conflicts with the runtime feature in the autocxx-bindgen.

  • Tests pass
  • Appropriate changes to README are included in PR

@adetaylor
Copy link
Collaborator

Thanks!

@adetaylor adetaylor merged commit ae4a4ee into google:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature flag for static still contains runtime autocxx-bindgen/clang-sys dependencies downstream
2 participants
@gen-xu @adetaylor