Support pprof profiling in BadWolf #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlucena
force-pushed
the
pprof
branch
3 times, most recently
from
4af6505 to
ec76870
Compare
thiagovas
approved these changes
Nov 3, 2020
Tati1701
approved these changes
Nov 3, 2020
| @@ -175,6 +220,59 @@ func REPL(od storage.Store, input *os.File, rl ReadLiner, chanSize, bulkSize, bu | |||
| done <- false | |||
| continue | |||
| } | |||
| if strings.HasPrefix(l, "start profiling") { | |||
There was a problem hiding this comment.
For a separate PR/Unralated to your changes:
Consider updating the loop to have a switch instead of several if strings.HasPrefix checks.
Remember: in Go, switch statements are more general than in other languages, so you can have cases checking for HasPrefix.
https://golang.org/doc/effective_go.html#switch
Besides being more readable, it can probably simplify the done <- false/continue repetitions. You might want to look at labels to control the flow here, rather than using the channel :)
There was a problem hiding this comment.
Thank you Tati! It is cool that switch can be this general in Go, we will keep this in mind for a future PR as well. =]
rbkloss
approved these changes
Nov 3, 2020
… appended to the same files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to allow the user to have more visibility on latency and memory metrics when using BadWolf, adding support for pprof profiling through BadWolf's CLI.
When in the terminal, after already entering the BadWolf's CLI with the command
bw bql, the user can now write:To start
pprofprofiling. The user can also specify the CPU profiling rate with the-cpurateflag below:Similarly, to stop it they can just write:
With profiling enabled, the metrics for latency and memory consumption for the BQLs executed will be printed into two files,
cpuprofileandmemprofile, that can then be consumed and visualized through thego pprofCLI tool.Commands such as
go tool pprof -http=":8081" bw cpuprofileopen in the browser an interface to visualize the CPU metrics: the user can see the graph of function calls made and the latencies involved, useful to identify bottlenecks; they can visualize the correspondent Flame Graph as well, and also an ordered list of the heaviest function calls made. Another useful command isgo tool pprof -pdf bw cpuprofile > cpuprofile.pdfto generate pdfs from the profiling files. Withmemprofilethe previouspprofcommands work similarly.