Use a config transition to set compilation_mode to "opt" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installer() rule by default depends now on targets built with '-c opt'
To disable this override of a command line flag use `compilation_mode = ""`
attribute:
```
installer(
name = "install_foo",
compilation_mode = "",
data = [":foo"],
)
```
Alternatively you can force a debug build:
```
installer(
name = "install_foo_dbg",
compilation_mode = "dbg",
data = [":foo"],
)
```
|
@juliexxia Please take a look (specifically |
juliexxia
reviewed
Feb 26, 2020
| @@ -91,14 +103,16 @@ def installer(name, data, executable = True, target_subdir = ""): | |||
|
|
|||
| Args: | |||
| name: A unique name of this rule. | |||
| compilation_mode: If not empty, sets compilation_mode of targets in data. | |||
There was a problem hiding this comment.
Apologies for not getting to this sooner! Just want to note that you're not only setting compilation_mode of targets in data but also of that entire subtree that is rooted in these data deps.
There was a problem hiding this comment.
Thanks for taking a look! Yes, this is intended - I want to make it easy to do the right thing and install an optimized build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installer() rule by default depends now on targets built with '-c opt'
To disable this override of a command line flag use
compilation_mode = ""attribute:
Alternatively you can force a debug build: